AllenInstitute / segmentation-labeling-app

Data pipeline and UI for human labeling of putative ROIs from 2p cell segmentations
Other
0 stars 0 forks source link

Investigate "green" movies #76

Closed wbwakeman closed 4 years ago

wbwakeman commented 4 years ago

Try to find repro case Try to understand and implement fix

Potentially look into hardware acceleration

kschelonka commented 4 years ago

@njmei Would you be able to take this one?

njmei commented 4 years ago

So a bit of preliminary sleuthing uncovered:

We are using x264 (AVC) and:

Firefox support for AVC is dependent upon the operating system's built-in or preinstalled codecs for AVC and its container in order to avoid patent concerns.

We maybe should ask folks for system specs including OS

pickles-bread-and-butter commented 4 years ago

I can't create a job to investigate this as I don't have permissions in the same AWS where the lambdas are deployed. I'll let someone else pick this up or someone can help me with permissions.

kschelonka commented 4 years ago

Hmm, your IAM role should have admin privileges. Which account are you using, and what exactly is the error message?

On Thu, May 7, 2020, 9:17 AM isaak-willett notifications@github.com wrote:

I can't create a job to investigate this as I don't have permissions in the same AWS where the lambdas are deployed. I'll let someone else pick this up or someone can help me with permissions.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AllenInstitute/segmentation-labeling-app/issues/76#issuecomment-625354147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFEJBX2DNLKFC7S6JBW623RQLNILANCNFSM4M22NR7A .

kschelonka commented 4 years ago

I would also recommend deploying a webpage locally rather than using a ground truth job. It will be easier to reproduce, control, and debug.

On Thu, May 7, 2020, 9:19 AM Kat Schelonka kschelon@gmail.com wrote:

Hmm, your IAM role should have admin privileges. Which account are you using, and what exactly is the error message?

On Thu, May 7, 2020, 9:17 AM isaak-willett notifications@github.com wrote:

I can't create a job to investigate this as I don't have permissions in the same AWS where the lambdas are deployed. I'll let someone else pick this up or someone can help me with permissions.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AllenInstitute/segmentation-labeling-app/issues/76#issuecomment-625354147, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFEJBX2DNLKFC7S6JBW623RQLNILANCNFSM4M22NR7A .

pickles-bread-and-butter commented 4 years ago

This is the account id I'm using: 606907419058. The error message is 400 AccessDeniedException: User: arn:aws:iam::606907419058:user/isaak.willett is not authorized to perform: iam:PassRole on resource: arn:aws:iam::606907419058:role/service-role/AmazonSageMaker-ExecutionRole-20200429T115429 Request ID: de5b921b-6e3a-4e2b-b49b-a85e8aef87ef This was using the predefined role. I also tried to create my own role with the right privileges for the buckets and it also gave me a 400 error. I ended up just working on a local host.

kschelonka commented 4 years ago

That's unexpected. And this is just trying to make a job in the console using the roles already created?

pickles-bread-and-butter commented 4 years ago

Yep, nothing fancy.

pickles-bread-and-butter commented 4 years ago

Jerome was able to reproduce this error on his machine in Firefox see attached videos. People using different codecs might have different abilities to decode and encode the videos.

Things to Investigate:

pickles-bread-and-butter commented 4 years ago

The videos are now encoded using VP9 but this has created problems on my windows machine where they are no longer supported.

njmei commented 4 years ago

@isaak-willett It sounds like the next step would be to investigate if there might be something wrong with how we are converting our images to videos via imageio-ffmpeg then...

1) Some argument to the imageio-ffmpeg write_frames function that stand out to me are: pix_fmt_in, macro_block_size, size.

2) I would also look into what version of ffmpeg is bundled with imageio-ffmpeg perhaps we need to use an updated version of ffmpeg.

pickles-bread-and-butter commented 4 years ago

I changed the output pixel format to yuv420p and it seems to be working, there is however vertical striping which I'm not sure if it is my monitor. I'm sending the videos to Jerome to get them run on a Mac.

kschelonka commented 4 years ago

If it isn't working for you, then I think we need to pursue other options. We have to support Windows machines.

On Fri, May 8, 2020, 7:51 AM isaak-willett notifications@github.com wrote:

I changed the output pixel format to yuv420p and it seems to be working, there is however vertical striping which I'm not sure if it is my monitor. I'm sending the videos to Jerome to get them run on a Mac.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/AllenInstitute/segmentation-labeling-app/issues/76#issuecomment-625853136, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIFEJBWGOOW5GZMMJFGWJ6DRQQL6LANCNFSM4M22NR7A .

pickles-bread-and-butter commented 4 years ago

Changed the output format to yuv420p, we had a slight bug from previous implementation where input shape to ffmpeg is (width, height) and we were supplying (row, col) didn't catch this because we weren't looking at non square videos. I fixed this and tested with Natalia and Jerome, they can both open in browsers but not in Quicktime. Jerome tested on VLC and Quicktime as well as browsers and it plays in VLC but not Quicktime.

kschelonka commented 4 years ago

Are you able to see it properly on your machine? No lines/artifacts?