AllenInstitute / sweep_qc_tool

manual quality control for intracellular electrophysiology experiments
GNU General Public License v3.0
1 stars 2 forks source link

52/display all sweeps #54

Closed kasbaker closed 4 years ago

kasbaker commented 4 years ago

View menu with checkable actions to filter which sweeps can be viewed has been added. By default, "Auto QC sweeps" is checked, which has the same functionality as before. If "Channel recording sweeps" is checked, then channel recording sweeps will be displayed. If neither is checked then all sweeps except for "Search" sweeps will be displayed.

sweep_qc_tool_view_menu

Previous and initial test pulses are saved for channel recording voltage clamp sweeps now.

sweep_qc_tool_vclamp_test_pulse

New tests were added to test sweep filtering functionality and new plotter behavior.

NileGraddis commented 4 years ago

A random thing I noticed while poking around with this build and the new mies nwbs (works great, btw): The menu option for displaying test sweeps is "auto qc sweeps" off. This seems counter-intuitive to me - I would imagine that checking a view option should be additive. What do you think @kasbaker ?

NileGraddis commented 4 years ago

re: sweep view checking. All unchecked displaying nothing (or some notion of "basic" sweeps) makes sense to me. We could just default to some pattern of checks

NileGraddis commented 4 years ago

closed by mistaken click, sorry