AllenInstitute / transcriptomic_clustering

improved clustering pipeline for transcriptomic data
Other
4 stars 1 forks source link

GH-12 Add de score calculation from de stats #89

Closed sgratiy closed 3 years ago

sgratiy commented 3 years ago

Problem: addresses step 4 in Merge For each pair, compute differentially expressed genes and score

Solution: Reproduce de_stats() from R, except that here it only returns the de score for the cluster pair as suggested by the merging module

Validation: unit tests

Note: I have added qdiff as part of de_pair_chisq . This way we do not need to modify de_stats.

I have dropped the wrapper function that computed and returned all the score metrics because it seemed redundant. Instead I propose usage as shown in test_calc_de_score_for_pair that provides the up/down genes and scores. I propose to directly include those calls into get_de_scores_for_pairs