AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior
Other
22 stars 6 forks source link

fixes get_params() issue #662

Closed alexpiet closed 4 years ago

alexpiet commented 4 years ago

The BehaviorOphysDataset had two related issues with how parameters were initialized. This PR fixes both of them, outlined in issue #660

  1. the include_invalid_rois parameter needed to be internally named _include_invalid_rois for the get/set parameter system to work. I checked all the files in the data_access module for name changes, but didnt check VBA beyond that module.

  2. I dont understand why but the two eye_tracking parameters that are defined in the constructor __init__ method for BehaviorOphysSession were not getting set when the BehaviorOphysDataset was created. So I explicitly call them in the call to the init() function, and that solves the problem!