AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior
Other
22 stars 6 forks source link

Merge dev into master #693

Closed dougollerenshaw closed 3 years ago

dougollerenshaw commented 3 years ago

Summary of changes in this PR:

To Do:

dougollerenshaw commented 3 years ago

@matchings: note that the allensdk_head tests are failing because of the path changes noted in issue #696. I'll work on that issue in a separate PR, but if you get this PR ready to merge before that issue is solved, I think we should go ahead and merge with the one failing test.

matchings commented 3 years ago

@dougollerenshaw im still about halfway through addressing all the comments in the PR (primarily adding documentation), and will let you know when its ready to merge. Sorry its taking me so long.

matchings commented 3 years ago

@dougollerenshaw I think this PR is ready to merge in, if we are ok with the known test failure associated with #696. Should I go ahead and do that, or do you want to do another once over to double check for anything that could break downstream analysis code?

dougollerenshaw commented 3 years ago

Let's merge in #701 first. That should take care of the failing tests on test-allendsdk_head