bumps to latest release of AllenSDK

AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior

Other

21 stars 6 forks source link

bumps to latest release of AllenSDK #729

Closed djkapner closed 3 years ago

djkapner commented 3 years ago

this may break things.

dougollerenshaw commented 3 years ago

Thanks @djkapner! We also need to make some changes to incorporate some of the import syntax changes that happened from AllenSDK 2.9.0 to 2.10.0. I will add those. I'd also like to add some tests that will run on CircleCI to verify.

From your slack comment:

BehaviorProjectCache is now VisualBehaviorOphysProjectCache
for that class the method get_session_table() is now get_ophys_session_table()
for that class the methof get_experiment_table() is now get_ophys_experiment_table()

djkapner commented 3 years ago

yep. I was just putting this here as a nudge/reminder that a new release has come out. I can stop doing that, if you have your own system going, let me know.

For AllenSDK, what we'd do is leave a branch/PR like this open, and make fixing PRs to it. When the tests on this PR pass, you're good (unless the coverage isn't complete...)

dougollerenshaw commented 3 years ago

Since we're already at allensdk 2.10.2, I'm going to close this PR and start a new one to target 2.10.2 compatibility.