search

AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior
Other
21 stars 6 forks source link

bugfixes in add_engagement_state_to_trials_table #742

Closed dougollerenshaw closed 3 years ago

dougollerenshaw commented 3 years ago

fixes two bugs in visual_behavior.data_access.reformat.add_engagement_state_to_trials_table

1) replaces np.argmin with pd.idxmin: argmin worked when I developed the function, but has suddenly stopped working. I changed my pandas version, which might explain why. Regardless, idxmin should be more reliable

2) fixed double assignment

Also adds a test on visual_behavior.data_access.reformat.add_engagement_state_to_trials_table.

Pinning hdmf at 2.4.0 to deal with this issue: https://github.com/AllenInstitute/AllenSDK/issues/2098