search

AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior
Other
21 stars 6 forks source link

add ISI and ephys to id_types #780

Open dougollerenshaw opened 2 years ago

dougollerenshaw commented 2 years ago

the data_access.from_lims.get_id_type function does not find IDs for ISI sessions. We should add ISI sessions and potentially extracellular ephys sessions.

DowntonCrabby commented 2 years ago

I have a branch I'm working on (preconditions_dev) where I refactored the get_id_type function so that it can now get

ophys_experiment_id ophys_session_id behavior_session_id specimen_id donor_id cell_roi_id cell_specimen_id ophys_container_id supercontainer_id

I can very easily add the isi and extracellular ephys sessions to that list as well

dougollerenshaw commented 2 years ago

@DowntonCrabby sounds good. What's your timeline for making a PR to get that merged? @seanmcculloch was having an issue with mouseseeks that would be resolved if this issue were resolved, so I figured he could implement this small fix pretty quickly to get himself unstuck.

DowntonCrabby commented 2 years ago

My timeline is probably end of week. If @seanmcculloch needs it sooner I can send him the individual functions (there are 3) to implement.

seanmcculloch commented 2 years ago

That sounds fine @DowntonCrabby Thanks!