AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior
Other
21 stars 6 forks source link

Preconditions dev #781

Closed DowntonCrabby closed 2 years ago

DowntonCrabby commented 2 years ago
DowntonCrabby commented 2 years ago

For the well known files, using the database may be better practice. Is a hard-coded dictionary required?

_Is there a reason you built your own lims connection and used mixin.select() rather than using database.py's db.limsquery?

DowntonCrabby commented 2 years ago

@seanmcculloch I know there were some changes you wanted to make. Is that still the case?

seanmcculloch commented 2 years ago

Using the lims / mtrain credentials works, though there is redundancy with database.py. Removing this redundancy is outside of the scope of this PR, so no changes needed.