update to use from_s3_cache by default

AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior

Other

22 stars 6 forks source link

update to use from_s3_cache by default #784

Closed matchings closed 3 years ago

alexpiet commented 3 years ago

Before merging @matchings can you merge this PR into update_nwb_loading?

https://github.com/AllenInstitute/visual_behavior_analysis/pull/786

alexpiet commented 3 years ago

@matchings

[x] loading.get_platform_paper_experiment_table() throws a bunch of warnings about trying to set on a copy of a slice.
[x] I'm getting an error visual_behavior.data_access.utilities has no attribute add_n_relative_to_novel_1
[x] experiment_table = loading.get_filtered_ophys_experiment_table() throws an error "local variable "experiments" referenced before assignment"

matchings commented 3 years ago

@alexpiet I believe i have addressed the issues you brought up above, however i want to point out that you should not be usingloading.get_filtered_ophys_experiment_table() for platform paper analysis anymore, as the default behavior of this function is to get data from lims.

The new functionloading.get_platform_paper_experiment_table() gets the final dataset from a set cache directory that contains the NWB files downloaded from AWS. This is what we should all be using going forward. @yavorska-iryna @farznaj

alexpiet commented 3 years ago

@matchings

Approved, and yes I was waiting to switch to get_platform_paper_experiment_table until these updates to VBA were done.