AllenInstitute / visual_behavior_analysis

Python package for analyzing behavioral data for Brain Observatory: Visual Behavior
Other
21 stars 6 forks source link

Circular imports #808

Closed alexpiet closed 2 years ago

alexpiet commented 2 years ago

data_access.loading imports data_access.reformat which in turn imports data_access.loading.

I dont know when this broke, but you can no longer import data_access.loading. What is confusing to me is I was pretty sure I was up to date on master and this was working last week. But it looks like there haven't been any changes to either file in months. I guess I was out of date?

alexpiet commented 2 years ago

Shockingly, it appears to matter the order in which certain modules are loaded

import visual_behavior.data_access.loading as loading
import visual_behavior.data_access.reformat as reformat

and

import visual_behavior.data_access.loading as loading
import visual_behavior.data_access.utilities as utilities

both work fine. but the following both raise exceptions:

import visual_behavior.data_access.utilities as utilities

Screen Shot 2022-04-20 at 2 28 10 PM

import visual_behavior.data_access.reformat as reformat

Screen Shot 2022-04-20 at 2 28 46 PM