search

AllenNeuralDynamics / aind-codeocean-pipeline-monitor

Package to manage monitoring a Code Ocean pipeline
MIT License
0 stars 0 forks source link

Required imports not available with default dependencies #19

Open bjhardcastle opened 4 hours ago

bjhardcastle commented 4 hours ago

Describe the bug Importing https://github.com/AllenNeuralDynamics/aind-codeocean-pipeline-monitor/blob/main/src/aind_codeocean_pipeline_monitor/job.py with the default project dependencies errors: aind_alert_utils and aind_data_schema_models are imported, but not available. https://github.com/AllenNeuralDynamics/aind-codeocean-pipeline-monitor/blob/e3c16abd11ed330230985c6b036384caf88f3b9b/src/aind_codeocean_pipeline_monitor/job.py#L12-L13

To Reproduce Steps to reproduce the behavior:

  1. Follow the steps in the current readme with the default project dependencies installed (not full)
bjhardcastle commented 4 hours ago

Looks like aind_data_schema_models is actually required and should be moved to default project dependencies.

aind_alert_utils is optional and could be imported with ... except ModuleNotFoundError:, or imported when used in _send_alert_to_teams().

bjhardcastle commented 3 hours ago

https://github.com/AllenNeuralDynamics/aind-codeocean-pipeline-monitor/blob/e3c16abd11ed330230985c6b036384caf88f3b9b/src/aind_codeocean_pipeline_monitor/job.py#L211 This also results in an error (on Windows) due to tzdata not being installed.