AllenNeuralDynamics / aind-data-asset-indexer

MIT License
0 stars 0 forks source link

ci: adds Dockerfile and modifies github actions workflow #28

Closed yosefmaru closed 6 months ago

yosefmaru commented 6 months ago

Closes #17

yosefmaru commented 6 months ago

I'll approve. It's not entirely clear how the environment variables set in ECS are transferred in the container. You might need an additional step to do that in the Dockerfile unless you've already tested for that.

The environment variables will be set in terraform (in the task definition resource). Every time an ECS task is run, the container running the task will get those variables from the task definition.