anatomical_coordinates should expect CCFCoords

[mekhlakapoor]

Describe the bug In SLIMS, the anatomical coordinates are listed as AP, ML, DV (which are only fields in CCF coords). The anatomical_coordinates field in ManipulatorModule expected Coordinates3d which has x, y, z.

To Reproduce Steps to reproduce the behavior:

1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots

Desktop (please complete the following information):

• OS: [e.g. iOS]
• Browser [e.g. chrome, safari]
• Version [e.g. 22]

Smartphone (please complete the following information):

• Device: [e.g. iPhone6]
• OS: [e.g. iOS8.1]
• Browser [e.g. stock browser, safari]
• Version [e.g. 22]

Additional context Add any other context about the problem here.

[saskiad]

We can't use CCFcoords for the anatomical coordinates. But you are correct that the ml/ap/dv vs x/y/z needs to be resolved. I might recommend a solution where there is a AnatomicalCoords that uses ml/ap/dv and that the targeted_ccf_coordinates use AnatomicalCoords and have a ccf version field. This will need to be in v2.0

[mekhlakapoor]

For now, how should I map these coordinates? I was planning to map ml->x, ap->y, and dv->z

[saskiad]

that's good. Will you add that in the note field?

[mekhlakapoor]

I can add it to notes