Closed dyf closed 1 year ago
I think specimen_id only belongs in Acquisition. Ephys and Ophys Session still use intact subject.
we need the procedure that creates specimens to be different ... not sure which procedure this is
there should be very few procedures that have different input and output specimens...
@saskiad Sorry, missed these comments somehow.
In the past we separated the concept of the Subject from the brain. Right now we are treating those concepts as the same. Not sure how useful it is to separate them, but Specimen could do that.
More important is handling slicing and dissection appropriately, e.g.:
Here the input specimen would be the "brain" (we could just allow Subject
for this), and the output would be a slice Specimen.
Other situations I have encountered:
The Patchseq example is part of the origin story for the term cell_specimen
in the past.
Summarizing offline conversation:
Specimen
s, each with a derivation_procedure
SpecimenProcedure
s, each with input and output specimens definedSpecimen.derived_by_procedure.input_specimen.derived_by_procedure...
I think I personally prefer (1).
@saskiad Sorry, missed these comments somehow.
In the past we separated the concept of the Subject from the brain.
We still do. When we remove the brain from the animal, it is a specimen
A specimen is a piece of tissue. If that tissue is sliced, it becomes new pieces of tissue with new specimen IDs. If the tissue is bathed in solution, it is the same piece of tissue.
- Some experiments extract ROIs from sections for bulk sequencing. Specimens would be Brain -> Slice(s) -> ROIs.
Specimens are physical things. If we remove a chunk of tissue for sequencing, that's a new specimen. If we trace a cell on a computer image, that is not a specimen.
- Some experiments extract ROIs from sections for bulk sequencing. Specimens would be Brain -> Slice(s) -> ROIs.
Specimens are physical things. If we remove a chunk of tissue for sequencing, that's a new specimen. If we trace a cell on a computer image, that is not a specimen.
Agree. In my example the ROIs are dissected out.
resolved by PR #170
Specimen is for keeping track of samples as they are created/subdivided by procedures.
Proposal:
Specimen
class toprocedures.py
input_specimen
andoutput_specimen
toProcedure
List[Specimen]
toProcedures
specimen_id
toEphysSession
,Acquisition
, andOphysSession
.