AllenNeuralDynamics / aind-data-schema

A library that defines AIND data schema and validates JSON.
MIT License
23 stars 16 forks source link

Add a `specimen` model #58

Closed dyf closed 1 year ago

dyf commented 1 year ago

Specimen is for keeping track of samples as they are created/subdivided by procedures.

Proposal:

saskiad commented 1 year ago

I think specimen_id only belongs in Acquisition. Ephys and Ophys Session still use intact subject.

saskiad commented 1 year ago

we need the procedure that creates specimens to be different ... not sure which procedure this is

saskiad commented 1 year ago

there should be very few procedures that have different input and output specimens...

dyf commented 1 year ago

@saskiad Sorry, missed these comments somehow.

In the past we separated the concept of the Subject from the brain. Right now we are treating those concepts as the same. Not sure how useful it is to separate them, but Specimen could do that.

More important is handling slicing and dissection appropriately, e.g.:

Here the input specimen would be the "brain" (we could just allow Subject for this), and the output would be a slice Specimen.

Other situations I have encountered:

The Patchseq example is part of the origin story for the term cell_specimen in the past.

dyf commented 1 year ago

Summarizing offline conversation:

I think I personally prefer (1).

saskiad commented 1 year ago

@saskiad Sorry, missed these comments somehow.

In the past we separated the concept of the Subject from the brain.

We still do. When we remove the brain from the animal, it is a specimen

saskiad commented 1 year ago

A specimen is a piece of tissue. If that tissue is sliced, it becomes new pieces of tissue with new specimen IDs. If the tissue is bathed in solution, it is the same piece of tissue.

saskiad commented 1 year ago
  • Some experiments extract ROIs from sections for bulk sequencing. Specimens would be Brain -> Slice(s) -> ROIs.

Specimens are physical things. If we remove a chunk of tissue for sequencing, that's a new specimen. If we trace a cell on a computer image, that is not a specimen.

dyf commented 1 year ago
  • Some experiments extract ROIs from sections for bulk sequencing. Specimens would be Brain -> Slice(s) -> ROIs.

Specimens are physical things. If we remove a chunk of tissue for sequencing, that's a new specimen. If we trace a cell on a computer image, that is not a specimen.

Agree. In my example the ROIs are dissected out.

saskiad commented 1 year ago

resolved by PR #170