AllenNeuralDynamics / aind-fip-dff

This capsule takes an input raw NWB file of fiber data and creates processed DFF traces
MIT License
0 stars 0 forks source link

Refactor Pipeline code #8

Closed rachelstephlee closed 2 months ago

rachelstephlee commented 3 months ago

See #45 for more information.

Generally, the issue is that there are a lot of functions that are duplicated across. We need to refactor to clean up the code.

Copying Alex's description here:

In this capsule: https://codeocean.allenneuraldynamics.org/capsule/9216710/tree (NWB-Packaging-FiberPhotometry-Base-Capsule)

In this repo https://github.com/AllenNeuralDynamics/aind-fip-dff, there are a lot of mentions of "old" and "new" processing methods. These should be replaced with descriptive versions of how the code works. No one will remember in a year what old and new mean.

alexpiet commented 3 months ago
Ahad-Allen commented 3 months ago

I've moved NWB util functions to the util repo, I am not sure if preprocessing functions should exist here or stay within the dff capsule, however. Should be easy to move them in either case.

Ahad-Allen commented 2 months ago

I recall @rachelstephlee did some work on the utils after my PR was merged, is my help still needed on this?

rachelstephlee commented 2 months ago

I didn't touch this, so if you think all the refactoring is completed, we can close this.