AllenNeuralDynamics / aind-metadata-entry-js

Metadata entry using javascript
https://metadata-entry.allenneuraldynamics.org
MIT License
1 stars 1 forks source link

Nested const values in refs won't render #102

Closed jtyoung84 closed 5 months ago

jtyoung84 commented 11 months ago

Describe the bug Nested consts inside of definitions won't render.

To Reproduce Steps to reproduce the behavior:

  1. Build a schema with a const in a defintion
  2. Notice it doesn't render as read-only

Expected behavior Consts should be readonly

Additional context We should fix this in the uiSchema. Alternatively, there is a pr in the rjsf repo to fix this issue.

helen-m-lin commented 6 months ago

This is still an issue. Ongoing investigation.

Example: When selecting Instrument > Objectives > Objective > Manufacturer, all nested const values are showing as blank, even though the schema has default values for Name, Abbreviation, Registry name and abbr, and Registry Identifier. image

Note: This is also seen in the rjsf playground: image

helen-m-lin commented 6 months ago

@jtyoung84 Created a quick minimum example that can be viewed with https://rjsf-team.github.io/react-jsonschema-form/. For now, it seems that on the 3rd nested layer, const values start disappearing.

min_example_const_issues.json min_example_const_issues_processed.json