search

AllenNeuralDynamics / aind-metadata-entry-js

Metadata entry using javascript
https://metadata-entry.allenneuraldynamics.org
MIT License
1 stars 1 forks source link

Incorrect default units #112

Closed mekhlakapoor closed 6 months ago

mekhlakapoor commented 10 months ago

Describe the bug Units with default units are defaulting to the wrong units.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://metadata-entry.allenneuraldynamics.org/
  2. Select "rig" schema and scroll to Mouse Platform
  3. Select Disc for mouse platform
  4. See that default unit does not show up (supposed to be cm)

Expected behavior The units rendered in the GUI should be defaulting as defined in aind-data-schema

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

jtyoung84 commented 8 months ago

@mekhlakapoor Please add details

mekhlakapoor commented 6 months ago

This seems to be resolved. Default units are showing up as expected for entire rig schema (added devices and checked units for each). Also passed through a couple of the other schemas, and played around with versions. We can close this ticket once @jtyoung84 does a check

jtyoung84 commented 6 months ago

I'll close this ticket. Helen spotted some issues with defaults in nested fields, but she's working on that in a separate ticket.