AllenNeuralDynamics / aind-metadata-entry-js

Metadata entry using javascript
https://metadata-entry.allenneuraldynamics.org
MIT License
1 stars 1 forks source link

Certain older schemas do not render due to definition error #131

Closed helen-m-lin closed 6 months ago

helen-m-lin commented 6 months ago

Describe the bug Certain older schemas do not render and cause app to crash with errors. Schema versions that cause errors:

To Reproduce Steps to reproduce the behavior:

  1. Go to https://metadata-entry.allenneuraldynamics.org/
  2. Click on 'Select schema'
  3. Select any schema impacted as described above (e.g. mri_session 0.2.6)
  4. See app has crashed and observe error in console.

Expected behavior The selected schema and version should render.

Screenshots image

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

jtyoung84 commented 6 months ago

1 - Catch error and display message 2 - If the schemas are really old, we can consider adding a filter to filter out versions less than a number 3 - Try to understand where this error is coming from

helen-m-lin commented 6 months ago

I tested all schemas/versions and found the following errors causing app crashes:

Cause: Unhandled errors were caused by incorrect state handling in the RenderForm component.