AllenNeuralDynamics / aind-metadata-entry-js

Metadata entry using javascript
https://metadata-entry.allenneuraldynamics.org
MIT License
1 stars 2 forks source link

Update rjsf and remove omit blur #182

Closed micahwoodard closed 2 months ago

micahwoodard commented 3 months ago

fixes #179 #160

micahwoodard commented 3 months ago

Empty Rig:

Fillled Rig:

I also noticed some buggy behavior on the camera assemblies and stick microscopes where they flash open and then collapse. I've included a video. I checked on dev, and the behavior persist so not sure if this is a bug or if maybe I'm missing data or something.

https://github.com/user-attachments/assets/ca22493d-a0fe-45e3-bd82-32d1330c2ae5

helen-m-lin commented 3 months ago

I also noticed some buggy behavior on the camera assemblies and stick microscopes where they flash open and then collapse.

Thanks for flagging that, Micah! I'll take a look. We had that issue previously in #160. The CustomTextWidget may need to be updated.

helen-m-lin commented 3 months ago

@micahwoodard I think the issue has to do with the decimal handler in schemaHandlers.js. Looks like if you swap the order of the optional decimal, things work.

prop.anyOf = [{ title: 'decimal', type: 'string', pattern: '^-?\\d+(\\.\\d{1,})?$' }, { type: 'null', title: 'null' }]
micahwoodard commented 3 months ago

Yay thanks for investigating that! Push a fix