search

AllenNeuralDynamics / aind-metadata-entry-js

Metadata entry using javascript
https://metadata-entry.allenneuraldynamics.org
MIT License
1 stars 1 forks source link

certain schemas from aind-data-schema >= 1.0 do not render correctly #187

Open helen-m-lin opened 3 weeks ago

helen-m-lin commented 3 weeks ago

Describe the bug aind-data-schema 1.0 uses a newer version of pydantic. The metadata entry app is unable to render certain schemas using these newer versions (e.g. unable to add Camera Assemblies in rigs). We added a hot fix to only allow schemas from before aind-data-schema 1.0 in prod, but we should still investigate this issue and add a fix.

To Reproduce Steps to reproduce the behavior:

  1. Go to https://metadata-entry.allenneuraldynamics-test.org/ (dev site does not currently have the hot fix)
  2. Click on 'rig' from the schema types dropdown
  3. Check that the rig version >= 1.0.0
  4. Attempt to add a Camera Assembly or Stick Microscope
  5. Observe that the app glitches and you are unable to add it.

Expected behavior All schemas from aind-data-schema >= 1.0.0 should render correctly.

helen-m-lin commented 1 week ago

@mekhlakapoor we had the same issue previously with adding CameraAssemblies and such. This was the fix: https://github.com/AllenNeuralDynamics/aind-metadata-entry-js/issues/160. I'm not sure why the pydantic update in aind-data-schema 1.0 breaks it again.