search

AllenNeuralDynamics / aind-metadata-mapper

Repository to help gather and map metadata from different sources
MIT License
0 stars 2 forks source link

eliminate np_session and npc_sessions from metadatamapper #164

Closed rcpeene closed 2 months ago

rcpeene commented 2 months ago

We just had a meeting with Ben and Arielle. We decided to keep npc_mvr and npc_ephys, but try to eliminate npc_sessions and np_session from the dependencies. Two things need to be done.

  1. np_session object and properties should be factored out of the Camstim class.
  2. npc_sessions.get_newscale_coordinates should be relocated to another place (npc_ephys I think?). This will be tracked here for Ben: https://github.com/AllenInstitute/npc_sessions/issues/122. And then the function call should be changed to accomodate the new namespace
jeromelecoq commented 2 months ago

@rcpeene is having issues with mtrain calls in np_session We are trying to figure out the way to do this (fetch script name and url).

rcpeene commented 2 months ago

Figured it out. We are able to get a session uuid from the pkl file and then can use that as input to a call to mtrain to get the regimen script url and name.

The rest of the refactoring was simple enough.

Done in PR #174