AllenNeuralDynamics / aind-metadata-service

Service to retrieve Labtracks/Sharepoint info using a REST API
MIT License
3 stars 1 forks source link

Missing Cage and Room Ids #145

Closed mekhlakapoor closed 10 months ago

mekhlakapoor commented 11 months ago

Describe the bug For subjects that are missing cage and room information, the metadata service is returning -99999999999999 (invalid return value).

To Reproduce Steps to reproduce the behavior:

  1. Search for subject info for subject_id=632269.
  2. See that cage_id=-99999999999999, room_id=-99999999999999
  3. See in the UI that cage number is "Empty"

Expected behavior We expect that if cage or room id is missing, that it returns None.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

saskiad commented 10 months ago

it sounds like this is going to be true for any subject that has been euthanized - which makes the housing information useless to us and we should probably remove it from the schema. Let's discuss in a planning meeting.

mekhlakapoor commented 10 months ago

Moving this ticket to blocked until we have this discussion. @saskiad should we wait to deploy the metadata-service until we figure this out?