search

AllenNeuralDynamics / aind-metadata-service

Service to retrieve Labtracks/Sharepoint info using a REST API
MIT License
3 stars 1 forks source link

Fix Merge Responses #154

Closed mekhlakapoor closed 8 months ago

mekhlakapoor commented 9 months ago

Describe the bug As a user, I want the client errors to better reflect the issues at hand. The procedures endpoint is currently not combining the 2 different messages from sharepoint and labtracks correctly

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

saskiad commented 9 months ago

service returns "valid model" when required fields are missing eg. http://aind-metadata-service/procedures/653980 This says the model is valid but there is no injection_volume field, which is a required field.

mekhlakapoor commented 9 months ago

service returns "valid model" when required fields are missing eg. http://aind-metadata-service/procedures/653980 This says the model is valid but there is no injection_volume field, which is a required field.

Created a new issue for this #158