AllenNeuralDynamics / aind-metadata-service

Service to retrieve Labtracks/Sharepoint info using a REST API
MIT License
3 stars 1 forks source link

Don't use model_construct #211

Open mekhlakapoor opened 3 months ago

mekhlakapoor commented 3 months ago

User story

As a developer, I want the pydantic models to validate correctly without recursion issues. Fix any model creations to not use model_construct

Acceptance criteria

Sprint Ready Checklist

Notes

Add any helpful notes here.

mekhlakapoor commented 3 months ago

Check whether we can create invalid models with other method without it throwing validation errors at the time of creation

jtyoung84 commented 3 months ago

We should try to create the model if possible, and if there are validation errors, we can use model_construct. But we should stop using model_construct as a default everywhere.