search

AllenNeuralDynamics / aind-metadata-service

Service to retrieve Labtracks/Sharepoint info using a REST API
MIT License
3 stars 1 forks source link

feat: remove endpoint label in title and search with enter #213

Closed micahwoodard closed 3 months ago

micahwoodard commented 3 months ago

fixes #208

micahwoodard commented 3 months ago

Do we want to remove highlight for metadata that has validation errors?

helen-m-lin commented 3 months ago

Do we want to remove highlight for metadata that has validation errors?

Maybe we should add a check so that certain error codes are red-highlighted. We can probably leave the success ones as is. Looking at these, I think 406 and 300 do not need to be red highlighted, @jtyoung84 what do you think?

https://github.com/AllenNeuralDynamics/aind-metadata-service/blob/52e593cc6fe4510c99c34903ce86146e7762ce6e/src/aind_metadata_service/client.py#L8-L18

jtyoung84 commented 3 months ago

Do we want to remove highlight for metadata that has validation errors?

Maybe we should add a check so that certain error codes are red-highlighted. We can probably leave the success ones as is. Looking at these, I think 406 and 300 do not need to be red highlighted, @jtyoung84 what do you think?

https://github.com/AllenNeuralDynamics/aind-metadata-service/blob/52e593cc6fe4510c99c34903ce86146e7762ce6e/src/aind_metadata_service/client.py#L8-L18

We probably don't need to highlight them.

micahwoodard commented 3 months ago

Okay makes sense to me! Here is a version where if the status code is 406 or 300, the text is just black. Where you thinking of just having the text in black or be in another color like green or darkorange?