search

AllenNeuralDynamics / aind-metadata-service

Service to retrieve Labtracks/Sharepoint info using a REST API
MIT License
3 stars 1 forks source link

Track Implant ID/Coverslip Type #215

Closed mekhlakapoor closed 7 months ago

mekhlakapoor commented 1 year ago

Is your feature request related to a problem? Please describe. add a field to craniotomy to track implant id/coverslip type (str in SWR). originally requested by @bjhardcastle in this issue: https://github.com/AllenNeuralDynamics/aind-metadata-service/issues/89

Describe the solution you'd like Add field and then map accordingly in the metadata-service

jtyoung84 commented 1 year ago

@mekhlakapoor Circle up with Saskia about this

mekhlakapoor commented 1 year ago

According to email from Ali, Implant/Coverslip ID are in the NSB database and they added more options

saskiad commented 8 months ago

@mekhlakapoor is this different from the implant_part_number field?

mekhlakapoor commented 8 months ago

uhhh it might be. when was implant_part_number added? The original request was in March 2023 so implant_part_number could've been added after

saskiad commented 8 months ago

yeah, I don't remember. It wasn't recently, but I'll see if I can dig it out.

saskiad commented 8 months ago

It was already part of the craniotomy schema prior to January 2023 ...

saskiad commented 8 months ago

@mekhlakapoor I don't think this is about creating a new field as it looks like we already have the field we need. I think it's that we aren't actually ingesting the implant part number currently, so it should be something to add to the service.