search

AllenNeuralDynamics / aind-ophys-utils

Repo for Ophys utils
MIT License
0 stars 0 forks source link

Video+array utils #36

Closed j-friedrich closed 1 year ago

j-friedrich commented 1 year ago

Adds array_utils and video_utils that are used within the registration capsule but are generally useful

j-friedrich commented 1 year ago

Those functions are taken from the ophys_etl_pipelines, thus have already been vetted. How do I "open a ticket to remove the test_example.py", and why not just remove it myself?

jtyoung84 commented 1 year ago

Those functions are taken from the ophys_etl_pipelines, thus have already been vetted. How do I "open a ticket to remove the test_example.py", and why not just remove it myself?

To open a ticket, you can click on the Issues tab and click the green New Issue button on the upper right.

It's up to you if you want to remove it here. My usual workflow is to have a one-to-one correspondence between a PR and a ticket in the Issues column. If I see something that's outside the scope of the original issue, I'll try to open a new ticket. For larger software projects with a dedicated QA team, it helps them know which Issues are being resolved with the latest changes and what to look out for when they test things. Also, sometimes seemingly simple things can spiral into a rabbit hole and block the fix for the original issue.