AllenNeuralDynamics / aind-watchdog-service

Data staging service that prepares acquistion data for cloud upload to Amazon S3 and Code Ocean processing.
https://allenneuraldynamics.github.io/aind-watchdog-service/
MIT License
2 stars 0 forks source link

remove models from repo and add to aind-data-transfer-models #18

Closed arielleleon closed 4 months ago

arielleleon commented 4 months ago

aind-data-transfer-models should contain configurations for aind-watchdog-service.

bruno-f-cruz commented 4 months ago

I'm not sure I completely follow this decision. There should be a separation of concerns between the two packages. If one needs to update the watchdog models, only the watchdog package should be bumped not the aind-data-transfer-models one I reckon?

Is there a dependency that I am not appreciating perhaps?

arielleleon commented 4 months ago

That's actually a fair point. My rational was to have all transfer related models in the same location for easy import so that someone building the model wouldn't need to import aind-watchdog-service. Let me think about it...

arielleleon commented 4 months ago

Closing because I agree here with @bruno-f-cruz