search

AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control
MIT License
5 stars 4 forks source link

LickVisualizer update #1049

Closed hagikent closed 2 days ago

hagikent commented 3 days ago

Describe changes:

What issues or discussions does this update address?

Addressing the following issue: https://github.com/AllenNeuralDynamics/aind-behavior-blog/issues/561

As Bonsai doesn't allow you to change the title of windows after compiling/starting, now Lick Visualizer uses Label function from Bonsai.GUI package and dynamically indicating Box info by fetching it from setting.json file.

Screenshot 2024-11-19 at 4 42 47 PM

Describe the expected change in behavior from the perspective of the experimenter

No. It just makes easier to tell correspondence between LickVis windows and Box#.

Describe any manual update steps for task computers

No.

Was this update tested in 446/447?

428-9-A / 447-3-C / 447-3-D

hagikent commented 3 days ago

@micahwoodard sorry I sent a minor commit before signing you out from GH-desktop at the rig, and it seems as if you co-authored...

XX-Yin commented 2 days ago

@hagikent Do you also intend to change the foraging.bonsai and foraging.bonsai.layout files? I just see a lot of changes not specific to the PR in *foraging.bonsai8 and foraging.bonsai.layout. It's fine for me. Just to check with you.

hagikent commented 2 days ago

@XX-Yin Yes, intended changes are both in .bonsai and .layout.

a lot of changes not specific to the PR

They are because I did final adjustment at a rig PC, inheriting local setting info that will be overrode anyways by OSC messages for each session. This PR is pure visualization update.