Open XX-Yin opened 2 days ago
Other than the name issue, this seems good to me. Can you share a new rig.json and session.json for approval from Saskia?
Are there any other issues left to implement, or is this ready to go?
Other than the name issue, this seems good to me. Can you share a new rig.json and session.json for approval from Saskia?
Are there any other issues left to implement, or is this ready to go?
It's ready for review. I will generate a new session and rig metadata tomorrow for review
@XX-Yin Can you add details to the PR about what issues were fixed in the metadata? Probably just copying the itemized list from the issue is sufficient.
Pull Request instructions:
Describe changes:
daq_names
. (Removed the behavior from the data stream and added the behavior to the stimulus epoch instead. And no daq names required.)session_end_time
is before the end of one of your data streams. The end time should be the last time of all data streams and stimulus epochs.stimulus_device_name
max_frame_rate
which was changed a while ago) (The max_frame_rate has been removed and replaced by frame_rate)frame_num
item specifically is blocking upload to DocDB. You can't have fields with ".csv" in the name. This information should live in the quality_control class (which was only recently added to the schema, but that's where it should live) (These fields should go to the qc and they are removed here)What issues or discussions does this update address?
resolved https://github.com/AllenNeuralDynamics/dynamic-foraging-task/issues/510
Describe the expected change in behavior from the perspective of the experimenter
No
Describe any manual update steps for task computers
No
Was this update tested in 446/447?
On my own computer