Answer the questions below in detail. Your responses will be emailed to experimenters.
If the experimenters must do anything new, provide detailed step by step instructions on the wiki
If computer maintainers need to manually update anything, provide detailed step by step instructions
Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
If you use the keyword "skip email" in the title, it will skip the email updates
Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
Merges from "production_testing" into "main" should use the keyword "update main"
Describe changes:
Previously, when a user pressed Start FIP workflow the button toggled colors. But this was confusing because the workflow could not be stopped from the GUI. Now the color will not change
Previously, Start Excitation could not be pressed unless the FIP workflow had already been started. However, @hagikent requests that users check the cables (using excitation) before starting the workflow. So I removed the requirement that the FIP workflow had been started before allowing for excitation. The Start button still checks that the FIP workflow has been started.
Users can now the FIP mode between Normal and Axon. The only difference is the excitation power. Normal sends the Teensy command c, whereas Axon sends the teensy command e (@hagikent can you double check I got that mapping correct)
Previously when QComboBox fields were modified by the user, the slot was connected to keyPressEvent which took no action. I added a function that simply logs the new value for debugging purposes.
Also resolves a small issue where loading a mouse does not "accept" the ID or experimenter fields (the text remain purple). I added a keyPressEvent which accepts them
What issues or discussions does this update address?
resolves #433
resolves #435
Describe the expected change in behavior from the perspective of the experimenter
The Start FIP Workflow button will not change color after you press it
You can press Start Excitation without starting the workflow first, to allow for checking cables.
When running an FIP mouse you need to set the FIP mode. This will default to Normal. Some mice for @ZhixiaoSu will have FIP mode = Axon for axonal imaging. An individual mouse will always have the same FIP mode.
Standard UI
Xinxin's UI
Describe any manual update steps for task computers
none
Was this update tested in 446/447?
[x] tested in 428
[x] Make sure it accurately changes the teensy command, and FIP power
[x] Make sure the parameter is saved and loaded correctly
@hagikent This is ready for review, and you should test to make sure it works with the updated Teensy
@XX-Yin @hanhou This is mostly FIP updates, but I made a couple other changes you should review
Pull Request instructions:
Describe changes:
Start FIP workflow
the button toggled colors. But this was confusing because the workflow could not be stopped from the GUI. Now the color will not changeStart Excitation
could not be pressed unless the FIP workflow had already been started. However, @hagikent requests that users check the cables (using excitation) before starting the workflow. So I removed the requirement that the FIP workflow had been started before allowing for excitation. TheStart
button still checks that the FIP workflow has been started.Normal
andAxon
. The only difference is the excitation power.Normal
sends the Teensy commandc
, whereasAxon
sends the teensy commande
(@hagikent can you double check I got that mapping correct)What issues or discussions does this update address?
Describe the expected change in behavior from the perspective of the experimenter
Start FIP Workflow
button will not change color after you press itStart Excitation
without starting the workflow first, to allow for checking cables.FIP mode
. This will default toNormal
. Some mice for @ZhixiaoSu will have FIP mode =Axon
for axonal imaging. An individual mouse will always have the same FIP mode.Standard UI
Xinxin's UI
Describe any manual update steps for task computers
Was this update tested in 446/447?