Add reward delivery to dev

[ZhixiaoSu]

Pull Request instructions:

• Please follow the update protocol
• Answer the questions below in detail. Your responses will be emailed to experimenters.
• If the experimenters must do anything new, provide detailed step by step instructions on the wiki
• If computer maintainers need to manually update anything, provide detailed step by step instructions
• Use markdown syntax in order for your comments to be rendered reliably in the email: "1." instead of "1)", use four spaces for indents.
• If you use the keyword "skip email" in the title, it will skip the email updates
• Merges from "develop" into "production_testing" should use the keyword "production merge" in the title for reliable indexing of updates
• Merges from "production_testing" into "main" should use the keyword "update main"

Describe changes:

1. Added 'reward delay' field to nwb.trials. It is a delay between choice time and reward delivery.
2. Additional description about 'reward_outcome_time': It is time when choice is registered.

   What issues or discussions does this update address?

   This columns makes it possible to calculate actual reward delivery time when there's a reward delay in session.

   Describe the expected change in behavior from the perspective of the experimenter

   There will be no change in behavior.

   Describe any manual update steps for task computers

   There will be no manual update,

   Was this update tested in 446/447?

   No, it is tested locally on my laptop and desktop.

Additional info:

In current version, 'reward_outome_time' is the time when reward is determined, not when it is delivered. If a choice is made, it's time of first lick, if not, it's time of end of lick window. It makes sense in sessions where there's no reward delay. But when we introduce a reward delay, this time should be called 'response_time' or 'decision_time' and additional 'reward_delay' information (not saved in nwb yet) should be added to calculate time of outcome.

Given how big impact this file may have downstream, minimum change is made here to enable analysis. One column called 'reward_delay' was added to NWB.

[XX-Yin]

@ZhixiaoSu There is an edge case. The old session does not have obj.TP_RewardDelay.

[ZhixiaoSu]

@ZhixiaoSu There is an edge case. The old session does not have obj.TP_RewardDelay.

@XX-Yin Can I fix it by first checking if it has the field? If it doesn't, I'll put it as 0.0.

[XX-Yin]

0.0

Yes, it will work. You can run the file directly to pass the test.

[ZhixiaoSu]

Update: set default to 0 to take care of earlier sessions without reward delay parameter by setting it to 0.