Closed XX-Yin closed 3 months ago
@XX-Yin Can you test this in 447, specifically on a FIP rig (with FIP running) @hagikent You should probably review this as well
@XX-Yin Can you test this in 447, specifically on a FIP rig (with FIP running) @hagikent You should probably review this as well
I have tested it on the behavior rig. The camera windows are open even the --no-bonsai-ide
was set. @alexpiet do you know how to hide these windows?
@XX-Yin Can you test this in 447, specifically on a FIP rig (with FIP running) @hagikent You should probably review this as well
I have tested it on the behavior rig. The camera windows are open even the
--no-bonsai-ide
was set. @alexpiet do you know how to hide these windows?
--no-bonsai-ide
hides the bonsai IDE, not any visualizer windows opened by the workflow. Settings_box#.csv
with whether we want the cameras to open.@XX-Yin Can you test this in 447, specifically on a FIP rig (with FIP running) @hagikent You should probably review this as well
I have tested it on the behavior rig. The camera windows are open even the
--no-bonsai-ide
was set. @alexpiet do you know how to hide these windows?
--no-bonsai-ide
hides the bonsai IDE, not any visualizer windows opened by the workflow.- We might need to include a flag in
Settings_box#.csv
with whether we want the cameras to open.
Do you know how to hide the visualizer?
One solution is to use a different layout file, but this increases maintenance.
If you use BoxD, BehaviorCameras and FIPvisualizer windows will be automatically popped up. (otherwise one cannot run experiments) This is saved in the layout file. When you don't need them, you can simply close them.
If you use BoxD, BehaviorCameras and FIPvisualizer windows will be automatically popped up. (otherwise one cannot run experiments) This is saved in the layout file. When you don't need them, you can simply close them.
This should only be true if you start the FIP workflow, right?
If you use BoxD, BehaviorCameras and FIPvisualizer windows will be automatically popped up. (otherwise one cannot run experiments) This is saved in the layout file. When you don't need them, you can simply close them.
BehaviorCameras
and FIPvisualizer
are in different bonsai workflow and layout files from the foraging.bonsai
and foraging.bonsai.layout
, right? I only changed the foraging.bonsai.layout
.
If you use BoxD, BehaviorCameras and FIPvisualizer windows will be automatically popped up. (otherwise one cannot run experiments) This is saved in the layout file. When you don't need them, you can simply close them.
BehaviorCameras
andFIPvisualizer
are in different bonsai workflow and layout files from theforaging.bonsai
andforaging.bonsai.layout
, right? I only changed theforaging.bonsai.layout
.
Yes, the FIP workflow is separate, and will launch the FIP visualizers and the behavior cameras.
@alexpiet @hagikent I think it can be merged, and people who don't use high-speed cameras can just close these windows.
@alexpiet @hagikent I think it can be merged, and people who don't use high-speed cameras can just close these windows.
I'm not sure I understand. Is the behavior of this PR to make the high speed camera windows always open up? This would be very annoying in 447. Can we just use the already existing setting in Settings_box#.csv
(HighSpeedCamera) to toggle whether we open the camera windows?
@alexpiet @hagikent I think it can be merged, and people who don't use high-speed cameras can just close these windows.
I'm not sure I understand. Is the behavior of this PR to make the high speed camera windows always open up? This would be very annoying in 447. Can we just use the already existing setting in
Settings_box#.csv
(HighSpeedCamera) to toggle whether we open the camera windows?
I don't know how to toggle the foraging.bonsai.layout
file from the code in the foraging.bonsai
. I am not sure if it's possible.
One solution is to use different foraging.bonsai.layout
files, but it will increase of complexity of maintenance.
@alexpiet @hagikent I think it can be merged, and people who don't use high-speed cameras can just close these windows.
I'm not sure I understand. Is the behavior of this PR to make the high speed camera windows always open up? This would be very annoying in 447. Can we just use the already existing setting in
Settings_box#.csv
(HighSpeedCamera) to toggle whether we open the camera windows?
Yes, the high-speed camera windows always open up.
@XX-Yin Bruno says there is no way to logically toggle which visualizers are open based on input settings. Therefore we need to just have the 447 RAs close the extra windows (or maintain two layout files).
Hi Alex, thanks for updating this. Sure, I can make some changes to this PR
Get Outlook for iOShttps://aka.ms/o0ukef
From: Alex Piet @.> Sent: Monday, June 17, 2024 1:27:14 PM To: AllenNeuralDynamics/dynamic-foraging-task @.> Cc: Xinxin Yin @.>; Mention @.> Subject: Re: [AllenNeuralDynamics/dynamic-foraging-task] Show video (PR #459)
@XX-Yinhttps://github.com/XX-Yin Bruno says there is no way to logically toggle which visualizers are open based on input settings. Therefore we need to just have the 447 RAs close the extra windows (or maintain two layout files).
— Reply to this email directly, view it on GitHubhttps://github.com/AllenNeuralDynamics/dynamic-foraging-task/pull/459#issuecomment-2174363067, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2CTX5U5FQKARAZBYHCIPFTZH5BCFAVCNFSM6AAAAABICKZ7G6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGM3DGMBWG4. You are receiving this because you were mentioned.Message ID: @.***>
Pull Request instructions:
Describe changes:
Updated the bonsai layout file to automatically open the video visualization when bonsai is started.
What issues or discussions does this update address?
https://github.com/AllenNeuralDynamics/aind-behavior-blog/issues/351#event-12543503251
Describe the expected change in behavior from the perspective of the experimenter
For behavior rigs, no. For ephys rigs, video visualization panels will be open automatically.
Describe any manual update steps for task computers
No
Was this update tested in 446/447?
Tested on my own computer.