Ensure Harp register dump at GUI startup, then log Harp device info

AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control

MIT License

5 stars 4 forks source link

Ensure Harp register dump at GUI startup, then log Harp device info #461

Open alexpiet opened 4 months ago

alexpiet commented 4 months ago

We should automatically log the Harp device core_version, firmware_version, and hardware version for the rig.json and the GUI log.

We should ensure we are logging the register dump from the device to ensure we are in a consistent state. This will log the versions for us, and we can add to the rig.json and GUI log.

https://harp-tech.org/protocol/Device.html, Common Registers and Operation (Device 1.2)
https://allenneuraldynamics.github.io/aind-harp-workshop-materials/articles/Logging.html#ask-for-a-device-register-read-dump

Steps:

modify bonsai workflow to ensure harp registers are dumped
use the information to log harp device into for rig.json, and GUI log.

bruno-f-cruz commented 3 months ago

After talking to @XX-Yin I suggest re-enabling the already existing pattern in the workflow:

Inside RestartLoggers

This should issue a request for a reading dump, 2 seconds after the loggers are triggered from the python GUI. Make sure that for each harp device connected to the rig, a corresponding Multicast subject exists inside the Defer operator.

alexpiet commented 2 months ago

@XX-Yin Can you implement Bruno's recommendations?

XX-Yin commented 2 months ago

It’s on my to-do list. I need testings.

Get Outlook for iOShttps://aka.ms/o0ukef

From: Alex Piet @.> Sent: Monday, July 15, 2024 1:16:02 PM To: AllenNeuralDynamics/dynamic-foraging-task @.> Cc: Xinxin Yin @.>; Mention @.> Subject: Re: [AllenNeuralDynamics/dynamic-foraging-task] Ensure Harp register dump at GUI startup, then log Harp device info (Issue #461)

@XX-Yinhttps://github.com/XX-Yin Can you implement Bruno's recommendations?

— Reply to this email directly, view it on GitHubhttps://github.com/AllenNeuralDynamics/dynamic-foraging-task/issues/461#issuecomment-2229322516, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A2CTX5QE6SHLHE6JXNI25RDZMQUYFAVCNFSM6AAAAABIEOWURSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRZGMZDENJRGY. You are receiving this because you were mentioned.Message ID: @.***>

alexpiet commented 1 month ago

@XX-Yin What is the timeline to implement this?

bruno-f-cruz commented 3 weeks ago

@ZhixiaoSu @Poofjunior This is what we need to ensure we know the state of the lickometer for the respective benchmarks

Poofjunior commented 3 weeks ago

@KanghoonJ