Add real time indicator of lick detector

AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control

MIT License

5 stars 4 forks source link

Add real time indicator of lick detector #499

Closed alexpiet closed 2 days ago

alexpiet commented 1 month ago

RAs request a visual indicator of lick detection to help with positioning the lick spouts.

STEPS: Check for incoming harp messages, add a little indicator to the GUI

hagikent commented 1 month ago

Does this have to be in the GUI? I don't know if the visualization in the GUI is fast enough. Instead, having a bonsai visualizer window would be more simple/straightforward and real-time? e.g. https://github.com/AllenNeuralDynamics/dynamic-foraging-task/assets/54397345/3f22b3c9-f3b1-4c8a-a1ee-c89fde873782

hagikent commented 1 month ago

It looks duplicated with: https://github.com/AllenNeuralDynamics/dynamic-foraging-task/issues/480 Seemingly @galenlynch thinks the same as I do?

@travisjramirez @NgD-Huy Can you guys watch the video linked in the above comment and let me know if this is enough for your need? Thanks.

NgD-Huy commented 1 month ago

This looks great, thank you

travisjramirez commented 1 month ago

The GUI looks good. Is the idea that both left and right licks will appear on the same GUI or will two separate windows need to be open?

hagikent commented 1 month ago

one window containing both Left/Right. might be possible to be integrated to the behavior video windows to reduce total number of windows (this particular example is from a single-lick spout behavior)

travisjramirez commented 1 month ago

One window would be great because we can always minimize! And you're correct the less extra windows the better.

hagikent commented 1 month ago

After confirming that it doesn't have to be the python GUI-level implementation with @alexpiet , I will work on it.

alexpiet commented 1 month ago

I dont care if we implement things in bonsai or python.
But if we do use bonsai, I request that (1) the left/right licks are combined, (2) users can close the lick viewer without disrupting the task, and (3) preferably, the lick viewer would be hidden/closed by default

hagikent commented 1 month ago

(1) and (2), easy. Not sure if (3) is possible though, since the editor is default not-open. I don't know alternative way to open a visualizer besides double-clicking corresponding nodes; do you?

alexpiet commented 1 month ago

I dont know either. Probably fine to skip for now