AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control
MIT License
5 stars 4 forks source link

Stall timer resets with any Harp message #517

Closed alexpiet closed 3 weeks ago

alexpiet commented 3 weeks ago

Pull Request instructions:

Describe changes:

Since we changed the punishment for early licking, trial durations have sometimes gotten long enough to trigger the stall timer. The stall timer was checking the elapsed time since the last trial start as a way of checking if bonsai had crashed. Now I reset the stall timer based on any harp message from bonsai. Therefore early licking cannot trigger the stall timer, since the licks will show up as harp messages.

What issues or discussions does this update address?

Describe the expected change in behavior from the perspective of the experimenter

Describe any manual update steps for task computers

Was this update tested in 446/447?

alexpiet commented 3 weeks ago

@XX-Yin @hanhou This is ready for review