AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control
MIT License
5 stars 4 forks source link

Move the `scratch` field in nwb to metadata json #527

Closed hanhou closed 2 weeks ago

hanhou commented 4 months ago

As a temporary solution, I previously stored session-related metadata in the nwb.scratch field: https://github.com/AllenNeuralDynamics/dynamic-foraging-task/blob/2fea58cc170beb75d6d92e31a9d7253e26c6bf57/src/foraging_gui/TransferToNWB.py#L153-L197

We should relocate all of them to session.json etc.

related issues:

@alexpiet @XX-Yin @Ahad-Allen

XX-Yin commented 4 months ago

I have asked Saskia where to store these fields in the session.json. waiting for response

hanhou commented 4 months ago

also tagging @hagikent here as he will be working on backfilling metadata json from previously generated nwbs.

hanhou commented 4 months ago

I have asked Saskia where to store these fields in the session.json. waiting for response

My understanding is:

What I'm not sure about:

XX-Yin commented 4 months ago

I know they can go to stimulus_epoch, but it does not make sense to me. These parameters should be for that session instead of for a specific stimulus (e.g. we have auditory stimulus and optogenetics stimulus, but foraging efficiency, total reward, finish rate ... are for that session instead of for auditory stimulus or optogenetics).

alexpiet commented 2 weeks ago

Resolved by https://github.com/AllenNeuralDynamics/NWB-Packaging-FiberPhotometry-Base-Capsule/pull/30