AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control
MIT License
5 stars 4 forks source link

Show video 2 #529

Closed XX-Yin closed 3 weeks ago

XX-Yin commented 3 weeks ago

Pull Request instructions:

Describe changes:

Updated the bonsai layout file to automatically open the video visualization when bonsai is started.

What issues or discussions does this update address?

https://github.com/AllenNeuralDynamics/aind-behavior-blog/issues/351#event-12543503251

Describe the expected change in behavior from the perspective of the experimenter

For behavior rigs, we can close these video windows manually if we don't use it. For ephys rigs, video visualization windows for bottom and right cameras will be open automatically.

Describe any manual update steps for task computers

No

Was this update tested in 446/447?

Tested on my own computer.

XX-Yin commented 3 weeks ago

@alexpiet @hanhou The original PR (https://github.com/AllenNeuralDynamics/dynamic-foraging-task/pull/459) had difficult to resolve conflicts in the bonsai files, so I created a new PR.

XX-Yin commented 3 weeks ago

@alexpiet I don't know how to label the VideoWriter window. Do you have any ideas?

alexpiet commented 3 weeks ago

@alexpiet I don't know how to label the VideoWriter window. Do you have any ideas?

No. I'll ask bruno. We can move ahead with the rest of this PR

XX-Yin commented 3 weeks ago

@alexpiet I don't know how to label the VideoWriter window. Do you have any ideas?

No. I'll ask bruno. We can move ahead with the rest of this PR

I have changed the layout file to open the video window by default.

alexpiet commented 3 weeks ago

Bruno says it requires updating bonsai. I made a separate issue: https://github.com/AllenNeuralDynamics/dynamic-foraging-task/issues/530

XX-Yin commented 3 weeks ago

Bruno says it requires updating bonsai. I made a separate issue: #530

Ok, let's update the bonsai first.

XX-Yin commented 3 weeks ago

I will merge this. We can label the window of video writer after updating the bonsai.