Closed alexpiet closed 2 weeks ago
@hanhou @XX-Yin This is ready for review
Should we start to add release type to the commit message?
https://github.com/AllenNeuralDynamics/aind-library-template?tab=readme-ov-file#semantic-release
@hanhou I'm not sure how to integrate that into the automatic PRs for the weekly merges to main
You are calling tag.yml
in aind-github-actions
, which in turn uses mathieudutour/github-tag-action@v6.1
(this line), right?
I guess how it works is that it will analyze the type
prefixes of all commit messages inside a PR and determine the highest level of change:
type
prefix, as before, it will always trigger a patch version bump by default. (See "default_bump " here)So there are two options for us:
Option 1 (what you described): we don't use type
prefix in the commit message as before. In this case, weekly PRs always bump the patch version number by default. When we need to tag a manual intervention, we manually bump the minor or major version.
Option 2: We adopt the Angular commit message conventions. In this case, if we want to indicate the requirement of manual intervention, we can add "BREAKING CHANGE:" to the footer of the commit message to bump the major version number. Otherwise, the github action automatically handles patch (fix) and minor (feat) version bumps for us.
I think Option 2 may be a better practice in the long run.
@hanhou Thanks for explaining that! Option 2 seems to be great.
Do we need to make any changes to this PR? I think we just need to enforce standards on commit messages
Pull Request instructions:
Describe changes:
0.0.0
, this will increment to0.0.1
, then0.0.2
and so on. I propose we manually bump the minor version (eg0.1.0
) when we have updates that requirement manual interventionforaging_gui.__version__
will reflect this version number. This will improve clarity of metadata and issue trackingWhat issues or discussions does this update address?
Describe the expected change in behavior from the perspective of the experimenter
Describe any manual update steps for task computers
Was this update tested in 446/447?