AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control
MIT License
5 stars 4 forks source link

Automatically bump foraging_gui version #535

Closed alexpiet closed 2 weeks ago

alexpiet commented 2 weeks ago

Pull Request instructions:

Describe changes:

What issues or discussions does this update address?

Describe the expected change in behavior from the perspective of the experimenter

Describe any manual update steps for task computers

Was this update tested in 446/447?

alexpiet commented 2 weeks ago

@hanhou @XX-Yin This is ready for review

hanhou commented 2 weeks ago

Should we start to add release type to the commit message?

https://github.com/AllenNeuralDynamics/aind-library-template?tab=readme-ov-file#semantic-release

image

alexpiet commented 2 weeks ago

@hanhou I'm not sure how to integrate that into the automatic PRs for the weekly merges to main

hanhou commented 2 weeks ago

You are calling tag.yml in aind-github-actions, which in turn uses mathieudutour/github-tag-action@v6.1 (this line), right?

I guess how it works is that it will analyze the type prefixes of all commit messages inside a PR and determine the highest level of change:

So there are two options for us:

Option 1 (what you described): we don't use type prefix in the commit message as before. In this case, weekly PRs always bump the patch version number by default. When we need to tag a manual intervention, we manually bump the minor or major version.

Option 2: We adopt the Angular commit message conventions. In this case, if we want to indicate the requirement of manual intervention, we can add "BREAKING CHANGE:" to the footer of the commit message to bump the major version number. Otherwise, the github action automatically handles patch (fix) and minor (feat) version bumps for us.

I think Option 2 may be a better practice in the long run.

alexpiet commented 2 weeks ago

@hanhou Thanks for explaining that! Option 2 seems to be great.

alexpiet commented 2 weeks ago

Do we need to make any changes to this PR? I think we just need to enforce standards on commit messages