search

AllenNeuralDynamics / dynamic-foraging-task

Bonsai/Harp workflow for Dynamic Foraging with Python GUI for visualization and control
MIT License
5 stars 4 forks source link

Making directions/orientations consistent across training-software modalities #668

Open hagikent opened 2 weeks ago

hagikent commented 2 weeks ago

@alexpiet @hanhou @XX-Yin @ZhixiaoSu @KanghoonJ @galenlynch @bwtan-allen See below for the feature request from RAs (discussed at this week's Tue9 meeting). I will take care of 1, 2, and 4 this week. @alexpiet could you please take care of 3? (or delegate it to @XX-Yin or someone else? @micahwoodard maybe?)

See this RAs' group agreement summarized by @ellahiltonvano https://github.com/AllenNeuralDynamics/aind-behavior-blog/discussions/596#discussioncomment-10478931

1. image 2. image 3. image 4. image

@galenlynch @KanghoonJ @ZhixiaoSu @XX-Yin I will try to make the flip functions conditional/optional so that you can make it off at ephys rigs just by changing a flag in the local setting json file.

hanhou commented 2 weeks ago

Sorry that I missed this discussion, but are we going to flip all downstream plots and code or just the GUI? I'm asking because this is in contrast to many downstream conventions that have been already in place. In all visualizations and simulations, we have been using LEFT=0 and RIGHT=1, which is also in line with papers published by the Cohen lab.

alexpiet commented 2 weeks ago

Downstream plots can use whatever convention we like. This is just for the acquisition computers.

hagikent commented 2 weeks ago

https://github.com/AllenNeuralDynamics/dynamic-foraging-task/pull/674 This PR will solve 1, 2, and 4. Could someone work on the GUI visualization?

hagikent commented 6 days ago

Someone still needs to take care of 3.