AllenNeuralDynamics / ephys-sorting-manual-curation

Repository for collecting manual curation data for spike-sorting
1 stars 0 forks source link

Feature: make CI action to register new curation files to CodeOcean #2

Closed alejoe91 closed 1 year ago

alejoe91 commented 1 year ago

User story

As a user, I want the curated files registered to Code Ocean, so I can analyze them on that platform.

Acceptance criteria

Sprint Ready Checklist

Notes

Add any helpful notes here.

jtyoung84 commented 1 year ago

@alejoe91 Can you review/modify the acceptance criteria to get it how you want it? Alternatively, I can also write a CI script that will save the json file to a database.

alejoe91 commented 1 year ago

@jtyoung84 I think @dyf wrote it up quite nicely! That's exacly what I had in mind :)

jtyoung84 commented 1 year ago

@alejoe91 Do you know if it's possible to easily save these directly to a bucket in s3?

alejoe91 commented 1 year ago

It's probably doable if we set AWS credentials as secrets. Would that be easier then to register them in CO?

jtyoung84 commented 1 year ago

I can set up a lambda function to watch for new files that land in an s3 bucket. The lambda function can then perform the registration in Code Ocean. It's mostly that I feel like we can remove the "saving to github" step if we're just copying the data over to s3 anyways. I don't like the idea of using GitHub as a database if we can avoid it.

alejoe91 commented 1 year ago

Yeah, but that's currently how FigURL does it, because it uses github login so it can actually write to a repo...so I don't think we can remove the Save to Github for now