Open ZhixiaoSu opened 1 month ago
Talked about it with David and Josh and they also agree on this. @jtyoung84 I'll make a PR to the upload script and we can discuss about it there
@jtyoung84 can we move on with the upload of the curation assets in the new format?
Yep, sounds good. David approved the PR. I left a couple of small comments, but we can move forward with it.
Thanks! I'll address the comments tomorrow morning :)
Issue: Since curation is organized by sessions and recording, we may end up with multiple curation files in each curation folder. (see here) They can be from different users curating the same kilosort result or even from different results of kilosort pipeline (e.g. version with and without bad channel removal).
And with current data asset upload rule, each curation asset will have all versions of curation.json (from different users, for different sorting results), making it hard to be used by a pipeline. (e.g. https://codeocean.allenneuraldynamics.org/capsule/1846086/tree)
@alejoe91 and I talked about different ways to solve this issue. One would be to modify the data asset content. Will it be possible to not upload the not-modified old curation files when creating a new data asset for a new/modified curation? And will it be possible to also name the curation data asset with the suffix appened to curation file? For exmaple, 'curated-opto-ZhixiaoSu' instead of 'curated'?