AllenSWDB / allenswdb.github.io

Other
2 stars 4 forks source link

Add information addressing invalid times #59

Open JEElsner opened 1 week ago

JEElsner commented 1 week ago

Don't think I've got the information fully fleshed out yet, hence the draft pr. It's mostly a collection of the information I've learned so far. I still need to talk to Josh about what this means more broadly and strategies for determining what data is affected.

Mostly adopted from information in the following places:

This resolves #24.

JEElsner commented 2 days ago

Got it! Aside from the lack of example, do you think there's enough information here, or is more detail necessary? I have yet to reach out to Josh, and I think I would need to if more information is required.

saskiad commented 2 days ago

Got it! Aside from the lack of example, do you think there's enough information here, or is more detail necessary? I have yet to reach out to Josh, and I think I would need to if more information is required.

I think this is pretty much what we need.

JEElsner commented 1 day ago

Okay, I made some changes to the writing, added examples of the get_invalid_times() method and NaN values in the LFP channel data.

I decided to stick this content at the end of the VCN LFP tutorial for now , since that seemed like the relevant place for it.

saskiad commented 1 day ago

Remind me: I believe that there's a warning when a session has invalid times when you first access the session data? Is that true? If so, calling that out is useful. Basically, if you pull a session and don't get a warning, you're all set, if you do get a warning, here's what it means and how to deal with it.

JEElsner commented 1 day ago

Yes, but only when you call session.spike_times, or possibly other functions that depend on it, like session.presentationwise_spike_times.

I'll add a note about that.

saskiad commented 1 day ago

Okay, I made some changes to the writing, added examples of the get_invalid_times() method and NaN values in the LFP channel data.

I decided to stick this content at the end of the VCN LFP tutorial for now , since that seemed like the relevant place for it.

I would put it in the vcnp-data-access page after the section on Data for individual sessions. This isn't a LFP specific thing.