search

AllenSeitz / DimDungeons

A Minecraft mod which adds proceedurally generated dungeons.
15 stars 13 forks source link

Ticking entity crash #48

Closed Catomax262 closed 1 year ago

Catomax262 commented 2 years ago

https://crashy.net/YFd1VmlCrFVz2Z19M4fN

AllenSeitz commented 2 years ago

Thank you! Which version of MC and this mod did the crash occur on?

That error is strange. Because 650 is clearly right there at the end of the allowed values list. But I will look into this.

Catomax262 commented 2 years ago

I am currently using 1.18, and the crash happened a little after i inserted the key, the portal did not want to appear for a bit and i think it crashed when it placed the portal

AllenSeitz commented 2 years ago

That makes sense. According to the call stack it did crash when transitioning the keyhole from the ticking state to the non-ticking state. I have a potential fix in the works already.

AllenSeitz commented 2 years ago

Does this happen every time, reliably? Or just once or sometimes? I couldn't replicate it but I could see where the problem might have been in the code.

Catomax262 commented 2 years ago

I can't reply to that with certainty, as it only happened the first time i activated the portal. Though, i remember it actually took like 20 seconds to light up the portal, and then the portal appeared but it crashed instantly.

AllenSeitz commented 2 years ago

Thank you. We'll see if my next patch fixes it.

david-why commented 2 years ago

Same issue here with Minecraft 1.19, Forge 41.0.45, and Dimensional Dungeons 164 1.19.0.

Does this happen every time, reliably? Or just once or sometimes?

No, not every time. It happens randomly. It happened on my server twice, my first time and another time by a different player. All the other times I enabled a portal, it functions normally.

Here is the crash report of the last crash, which happened this morning. crash-2022-07-21_06.04.09-server.txt

AllenSeitz commented 2 years ago

I believe that version 166 which I am about to upload to Curseforge in the next 5 minutes will fix this.

Thank you for your reports!

david-why commented 2 years ago

Thanks for the quick update!

I can't test if the patch fixes the problem because other mods our server is using do not currently support new Forge versions (or at least I think so). That's why our server is still running on 41.0.45 :-( Maybe I'll check the other mods out and see if they upgraded.

MattB70 commented 2 years ago

Different error, but same reproduction steps. 1.18.2 dimdungeons-166-forge-1.18.2 Server log: https://gist.github.com/MattB70/20f706809e509c705db4f3451222fa6f Client logged nothing of value

Player report: image

AllenSeitz commented 2 years ago

I know this one! It's a different issue but it is one that has been reported before.

The mod is trying to nametag a mob, but the mob was null because it wasn't allowed to spawn. For the person who reported the issue the problem was another mod "Bad Mobs" that was enforcing a sort of ban list on the modpack. The fix was to go into the dimdungeons config and remove or replace the banned mobs with something else. (Which the modpack designer should have done, but they didn't test.)