AllenSeitz / DimDungeons

A Minecraft mod which adds proceedurally generated dungeons.
15 stars 13 forks source link

Exception in server tick loop crash on SMP #64

Open katubug opened 1 year ago

katubug commented 1 year ago

So we got this crash tonight: https://pastebin.com/ffKdD9Gq

User reports they had just used the key to open the portal when they got booted with a "Server Closed." They were using a normal portal key and they were not in a claimed chunk.

User also reports that they were doing stuff with the mod just fine yesterday, and that the portal was active when the server restarted just now.

AllenSeitz commented 1 year ago

Oh my god. In the latest version I wrote some code that only works in a dedicated client. It will crash if run on a server. I'm such an idiot.

For a fast fix, remove the rooms "tower_1" and "tower_2" in the common config. I'm sorry. I have to fix this for multiple versions now.

katubug commented 1 year ago

You're not an idiot, knock that off. 💗 Mistakes are perfectly acceptable, it's just a game after all! Thanks for your quick response and the workaround, I'll get that implemented on my end.

Thanks again!

On Wed, Jun 28, 2023, 4:56 AM Catastrophe573 @.***> wrote:

Oh my god. In the latest version I wrote some code that only works in a dedicated client. It will crash if run on a server. I'm such an idiot.

For a fast fix, remove the rooms "tower_1" and "tower_2" in the common config. I'm sorry. I have to fix this for multiple versions now.

— Reply to this email directly, view it on GitHub https://github.com/AllenSeitz/DimDungeons/issues/64#issuecomment-1611116662, or unsubscribe https://github.com/notifications/unsubscribe-auth/AE7XE5VCQBNGMZMIZUVA6Z3XNP5VXANCNFSM6AAAAAAZVALQAQ . You are receiving this because you authored the thread.Message ID: @.***>

AllenSeitz commented 1 year ago

Should be fixed in the latest version. (I just removed the whole locked chests feature.)