search

AllenSeitz / DimDungeons

A Minecraft mod which adds proceedurally generated dungeons.
15 stars 12 forks source link

Portal doesn't open #67

Open cfnnit opened 1 year ago

cfnnit commented 1 year ago

image

The dungeon on the other side was deleted.

but this is my first attempt at creating a dungeon and the other keys say the same thing.

AllenSeitz commented 1 year ago

Which version are you playing on? And is this single player or on a dedicated server?

That error is only supposed to appear if the chunk data for the dungeon dimension is deleted. (Or if someone were to go in and manually break all the blocks in the entrance room.) On some servers the practice of resetting a dimension is common and this error message is intended to save you from teleporting into the void with no floor.

cfnnit commented 1 year ago

I'm sorry, I forgot to include the information needed to create an issue. 1.19.2 on a multiplayer server I am using dimdungeons-178-forge-1.19.0 and personal dimensions work fine.

AllenSeitz commented 1 year ago

I was unable to reproduce your problem, but I am still looking into it. If you can think of any other information that might help please let me know. (Such as anything that might make your server special.)

AmphyEX commented 1 year ago

Hello, I am also having this issue. I am using my own modpack, "Minecraft: Community Edition." https://www.curseforge.com/minecraft/modpacks/minecraft-community-edition

latest.log (Had just deleted the config file to get fresh config, just in case that was the issue)

Can't seem to find any reason or error log. Very strange issue.

AmphyEX commented 1 year ago

UPDATE: This seems to be caused by the mod https://www.curseforge.com/minecraft/mc-mods/dimensional-threading-reforged

AllenSeitz commented 1 year ago

Thank you! I've never seen Dimensional Threading Reforged before but that definitely makes sense.

I don't know what else to say. I don't think I do anything that isn't thread safe, but individual dimensions aren't supposed to be threaded anyway? That is a risky change that DTR is making.

The use case DTR seems to be designed for is a situation where one player is zooming with fireworks and an elytra in the Overworld and generating a ton of chunks, while a second player does the same thing in The End. But this is not common. But even in that case both threads end up writing to the same hard drive and sharing other resources anyway so I'm not sure it really matters.

Dimensional Dungeons is a very passive mod. I use no mixins or core mods, no hacks, and everything I do is done cleanly through the Forge API. Maybe the way I build certain chunks slowly over a series of ticks is giving DTR trouble? But my code is doing its work the conventional way.

DTR has the following notice on their CurseForge page:

This mod might probably have some incompatibilities with other mods. Most of the time, it can only be fixed by the specific mods (making their code and used data structures thread-safe). This includes: AE2, Create, Bigger Reactors and Chunky Pregenerator

Being incompatible with AE2 and Create seems suspicious to me. I don't think it's fair to ask other mods to change their code to be thread safe when the code in question isn't supposed to be threaded in the first place!