Menu sides are displaced

[GoogleCodeExporter]

1. Enter the menu
2. Look at the misplaced sides

Look at the attached capture

Original issue reported on code.google.com by jean.cha...@gmail.com on 22 Sep 2010 at 1:57

Attachments:

• wagic_bug.png

[GoogleCodeExporter]

Damn, thanks.
I assume this happens on Linux ? We don't have the problem on the PSP or on 
windows, but I've seen it in the N900 port.

Original comment by wagic.the.homebrew@gmail.com on 22 Sep 2010 at 10:59

[GoogleCodeExporter]

Original comment by wagic.the.homebrew@gmail.com on 22 Sep 2010 at 10:59

• Added labels: Priority-High
• Removed labels: Priority-Medium

[GoogleCodeExporter]

This has to do with rotations.
In SimpleMenu.cpp, the following line:
renderer->RenderQuad(side, x - SIDE_SIZE / 2, y + height - 5, -M_PI/2, height - 
10);

replacing -M_PI/2 with M_PI/2 solves the issue. However, of course, then the 
issue happens on OpenGL1 and the PSP.

Could it be because some coordinates are reversed in openGL2?

Original comment by wagic.the.homebrew@gmail.com on 23 Sep 2010 at 1:32

[GoogleCodeExporter]

in renderQuad, replacing
esRotate(&mvpMatrix, -angle*RAD2DEG, 0.0f, 0.0f, 1.0f);
with
esRotate(&mvpMatrix, angle*RAD2DEG, 0.0f, 0.0f, 1.0f);
fixes the issue, and overall seems to make the rotations behave much more like 
in the opengl1 version

Question is: is this the good fix, or
1) is the previous version of JGE incorrect ?
or
2) is esRotate incorrect, in which case the fix should be done there ?

Original comment by wagic.the.homebrew@gmail.com on 23 Sep 2010 at 1:43

[GoogleCodeExporter]

fixed in r2300 with the above fix.
Please verify (both Linux and N900 if possible)

Original comment by wagic.the.homebrew@gmail.com on 23 Sep 2010 at 4:01

[GoogleCodeExporter]

Original comment by wagic.the.homebrew@gmail.com on 23 Sep 2010 at 4:05

• Changed state: Fixed

[GoogleCodeExporter]

For comment 4 I think -angle*RAD2DEG is correct and new-added esRotate() seems 
to place the matrix in an wrong order. Please check r2303.

Original comment by linshier@gmail.com on 23 Sep 2010 at 5:22

[GoogleCodeExporter]

Seems to be working under linux

Original comment by jean.cha...@gmail.com on 23 Sep 2010 at 8:20