chore: Refactor code quality issues

Allenxuxu / gev

🚀Gev is a lightweight, fast non-blocking TCP network library / websocket server based on Reactor mode. Support custom protocols to quickly and easily build high-performance servers.

MIT License

1.73k stars 194 forks source link

chore: Refactor code quality issues #72

Closed powerexploit closed 3 years ago

powerexploit commented 3 years ago

Description

Hey 👋 , I'm member of the Developer Outreach team at DeepSource and ran DeepSource analysis on my fork of the repo. It found some interesting code quality improvements to consider.

This PR fixes a few of the issues detected for you to assess if it is right for you. Happy to provide the tweaks separately otherwise :)

Important changes

Fix check for empty string
Remove unnecessary use of slice
Added .deepsource.toml file for continuous analysis on bug risks/performance/code-quality issues

Type of change

[x] Antipattern
[ ] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines of this project
[ ] I have performed a self-review of my own code

Allenxuxu commented 3 years ago

Thanks 🥳

powerexploit commented 3 years ago

Thanks @Allenxuxu ! Activating analysis will help you to continuously analyze repo for code quality issues and fix commonly occurring issues using the auto-fix feature.

To activate DeepSource you just need to follow these small steps:

Install DeepSource on your repository here.
create .deepsource.toml configuration which you can use to configure your analysis settings.

Note: This PR already have .deepsource.toml file so after merging you don't need to create this one.
Activate analysis here

powerexploit commented 3 years ago

Thanks @Allenxuxu ! Activating analysis will help you to continuously analyze repo for code quality issues and fix commonly occurring issues using the auto-fix feature.

To activate DeepSource you just need to follow these small steps:

Install DeepSource on your repository here.

create .deepsource.toml configuration which you can use to configure your analysis settings.

Note: This PR already have .deepsource.toml file so after merging you don't need to create this one.

Activate analysis here

hey @Allenxuxu , please have a look.

Allenxuxu commented 3 years ago

Thanks @Allenxuxu ! Activating analysis will help you to continuously analyze repo for code quality issues and fix commonly occurring issues using the auto-fix feature. To activate DeepSource you just need to follow these small steps:

Install DeepSource on your repository here.

create .deepsource.toml configuration which you can use to configure your analysis settings.

Note: This PR already have .deepsource.toml file so after merging you don't need to create this one.

Activate analysis here

hey @Allenxuxu , please have a look.

I have installed it, but there seems to be something wrong

powerexploit commented 3 years ago

Thanks @Allenxuxu ! Activating analysis will help you to continuously analyze repo for code quality issues and fix commonly occurring issues using the auto-fix feature. To activate DeepSource you just need to follow these small steps:

Install DeepSource on your repository here.

create .deepsource.toml configuration which you can use to configure your analysis settings.

Note: This PR already have .deepsource.toml file so after merging you don't need to create this one.

Activate analysis here

hey @Allenxuxu , please have a look.

I have installed it, but there seems to be something wrong

Hey @Allenxuxu ! To activate analysis go to settings > click on Activate Analysis. Screenshot from 2021-04-05 01-36-06

Allenxuxu commented 3 years ago

@ankitdobhal It works now. Thanks 🥳