search

Aller-Couleur / handlebars-i18n

handlebars-i18next.js adds the internationalization features of i18next and Intl to handlebars.js
Other
16 stars 6 forks source link

chore(deps): upgrade #38

Closed dargmuesli closed 2 years ago

dargmuesli commented 2 years ago

Working on updating dependencies ... give me a sec

github-actions[bot] commented 2 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

fwalzel commented 2 years ago

Hey Jonas, I made some minor fixes in dev branch and merged them to the master. Semantic-release action runs, succeeds but does not release a new version 1.4.1 or 1.5.0. Do you have ideas, what could bet the reason maybe? [Cheers!] Bildschirmfoto 2022-03-30 um 16 18 53 Bildschirmfoto 2022-03-30 um 16 18 20

dargmuesli commented 2 years ago

Line https://github.com/Aller-Couleur/handlebars-i18n/runs/5754263068?check_suite_focus=true#step:3:47 and the following reveal that "no commit should trigger a release". That means that no commit indicates changes that would require a release. This decision is made possible through conventionalcommits. If you want a feature to be released automatically, name the feature-including commit "feat: make x do y" with feat: indicating a feature, which results in a minor version upgrade (1.2.3 -> 1.3.3). A "fix: blabla" would result in 1.2.3 -> 1.2.4 and a "chore: blabla" or "ci: blabla" would not trigger a new release. There might be other categories, but I get along with those just fine.

fwalzel commented 2 years ago

Thanks a lot! That helped.